factory contract integration testcases #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemonem
reviewed
Nov 25, 2024
joemonem
reviewed
Nov 25, 2024
| ); | ||
| } | ||
|
|
||
| add_liquidity( |
There was a problem hiding this comment.
In cross-chain test cases we need to set assertions on the sending and receiving chain to make sure everything is working as expected. Errors on the receiving chain won't show here.
This applies to all cases where were expect the transaction to work.
There was a problem hiding this comment.
@joemonem fixed some changes let me know if there should be any other assertions that need to be added
Abhishek-1857
force-pushed
the
test/factory-tests
branch
from
87992d3 to
8b34b7e
Compare
joemonem
reviewed
Dec 18, 2024
| }, | ||
| }, | ||
| slippage_tolerance_bps: 100, // 1% slippage tolerance | ||
| timeout: None, // 10 minutes in seconds |
There was a problem hiding this comment.
timeout is None, but the comment says 10 minutes in seconds
|
Try merging the development branch into this one to resolve merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Added integration test cases for core functionalities in the factory contract, including
create pool,add liquidity,register token, andswap token. These tests ensure correctness and robustness for essential contract operations, along with edge case validation for handling unexpected inputs or scenarios.Type of Change
Related Issue
None
Testing
integration tests added for factory contract
Checklist
Screenshots (if applicable)
None
Additional Notes
None